[webkit-reviews] review granted: [Bug 185617] Keyboard focus should exit fullscreen. : [Attachment 341281] Patch

Tue May 29 17:41:10 PDT 2018

Ryosuke Niwa <rniwa at webkit.org> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 185617: Keyboard focus should exit fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=185617

Attachment 341281: Patch

https://bugs.webkit.org/attachment.cgi?id=341281&action=review

--- Comment #12 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 341281
  --> https://bugs.webkit.org/attachment.cgi?id=341281
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341281&action=review

> LayoutTests/fullscreen/full-screen-exit-on-keyboard-focus.html:47
> +		   setTimeout(function() {

I think we should expose some boolean indicating the fullscreen transition had
finished or not via internals,
and then we can poll that value here instead of 500ms. I'm afraid the test will
be flaky in some slow bots otherwise.
Namely, set this Document flag true in
Document::webkitDidEnterFullScreenForElement
and clear it in Document::webkitWillEnterFullScreenForElement and
Document::webkitWillExitFullScreenForElement

>> LayoutTests/fullscreen/full-screen-exit-on-keyboard-focus.html:77
>> +<body Xonmousedown="doMouseDown()">
> 
> Xonmousedown?

Plase remove this as we discussed in person.