[webkit-reviews] review granted: [Bug 186064] Add a version of JSVirtualMachine shrinkFootprint that runs when the VM goes idle : [Attachment 341536] patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 186064: Add a version of JSVirtualMachine shrinkFootprint that runs when
the VM goes idle
https://bugs.webkit.org/show_bug.cgi?id=186064

Attachment 341536: patch

https://bugs.webkit.org/attachment.cgi?id=341536&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 341536
  --> https://bugs.webkit.org/attachment.cgi?id=341536
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341536&action=review

r=me

> Source/JavaScriptCore/runtime/VM.cpp:785
> +	   heap.collectNow(Synchronousness::Sync);

This didn't pick up your Full GC fix.