[webkit-reviews] review granted: [Bug 185379] [ESNext][BigInt] Implement support for "<" and ">" relational operation : [Attachment 341164] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has granted Caio Lima
<ticaiolima at gmail.com>'s request for review:
Bug 185379: [ESNext][BigInt] Implement support for "<" and ">" relational
operation
https://bugs.webkit.org/show_bug.cgi?id=185379

Attachment 341164: Patch

https://bugs.webkit.org/attachment.cgi?id=341164&action=review




--- Comment #23 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 341164
  --> https://bugs.webkit.org/attachment.cgi?id=341164
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341164&action=review

r=me with nit.

> Source/JavaScriptCore/runtime/Operations.h:262
> +	       bool result = bigIntCompareLess(callFrame, p1, p2);
> +	       RETURN_IF_EXCEPTION(scope, false);
> +	       return result;

Use,

scope.release();
return bigIntCompareLess(callFrame, p1, p2);