[webkit-reviews] review granted: [Bug 184267] Array.prototype.concat with Proxy : [Attachment 341460] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 29 08:59:57 PDT 2018
Saam Barati <sbarati at apple.com> has granted Caitlin Potter (:caitp)
<caitp at igalia.com>'s request for review:
Bug 184267: Array.prototype.concat with Proxy
https://bugs.webkit.org/show_bug.cgi?id=184267
Attachment 341460: Patch
https://bugs.webkit.org/attachment.cgi?id=341460&action=review
--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 341460
--> https://bugs.webkit.org/attachment.cgi?id=341460
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=341460&action=review
> Source/JavaScriptCore/ChangeLog:11
> + This incorrectly treated prevented Proxy objects from being spread
when
“treated prevented” => prevented
> Source/JavaScriptCore/ChangeLog:12
> + they were the only argument passed to A.p.concat(), violating
ECMA-262.
Nit: I’d just spell out Array.prototype.concat
> JSTests/ChangeLog:8
> + Before this patch, the fast case for Array.prototype.concat was
taken if
Don’t think you need to repeat the same text in this changelog here
More information about the webkit-reviews
mailing list