[webkit-reviews] review granted: [Bug 185983] [Wi-Fi Assertions] Track whether WiFiAssertionHolder should actually hold a Wi-Fi assertion : [Attachment 341293] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 185983: [Wi-Fi Assertions] Track whether WiFiAssertionHolder should
actually hold a Wi-Fi assertion
https://bugs.webkit.org/show_bug.cgi?id=185983

Attachment 341293: Patch

https://bugs.webkit.org/attachment.cgi?id=341293&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 341293
  --> https://bugs.webkit.org/attachment.cgi?id=341293
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341293&action=review

> Source/WebKit/NetworkProcess/cocoa/WiFiAssertionHolder.mm:48
> +    holdWiFiAssertion(*this);

Seems odd to call hold and release if shouldHold is false