[webkit-reviews] review granted: [Bug 186042] [Extra zoom mode] "Significant area painted" rendering progress event is rarely fired : [Attachment 341467] Fix macOS build

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 186042: [Extra zoom mode] "Significant area painted" rendering progress
event is rarely fired
https://bugs.webkit.org/show_bug.cgi?id=186042

Attachment 341467: Fix macOS build

https://bugs.webkit.org/attachment.cgi?id=341467&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 341467
  --> https://bugs.webkit.org/attachment.cgi?id=341467
Fix macOS build

View in context: https://bugs.webkit.org/attachment.cgi?id=341467&action=review

> Source/WebCore/page/Page.cpp:1863
> +    relevantViewRectWidth = std::min<float>(viewRect.width().toFloat(),
relevantViewRectWidth);

Likely we should consider doing this everywhere at some point.

> Tools/TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:58
> + at implementation RenderingProgressHandler {
> +    BlockPtr<void(_WKRenderingProgressEvents)> _handler;
> +}

If you use TestNavigationDelegate, you can get rid of this class entirely.