[webkit-reviews] review granted: [Bug 186019] [LFC] Add Rect interface to Display::Box : [Attachment 341423] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 186019: [LFC] Add Rect interface to Display::Box
https://bugs.webkit.org/show_bug.cgi?id=186019

Attachment 341423: Patch

https://bugs.webkit.org/attachment.cgi?id=341423&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 341423
  --> https://bugs.webkit.org/attachment.cgi?id=341423
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341423&action=review

> Source/WebCore/layout/displaytree/DisplayBox.h:114
> +    LayoutUnit top() const { return m_rect.top(); }
> +    LayoutUnit left() const { return m_rect.left(); }
> +    LayoutUnit bottom() const { return m_rect.bottom(); }
> +    LayoutUnit right() const { return m_rect.right(); }

I guess these helpers are used a lot? box.top() is not that much more compact
than box.rect().top().