[webkit-reviews] review canceled: [Bug 170553] [GTK] Misplaced right click menu on web page due to deprecated gtk_menu_popup() : [Attachment 341451] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has canceled Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 170553: [GTK] Misplaced right click menu on web page due to deprecated
gtk_menu_popup()
https://bugs.webkit.org/show_bug.cgi?id=170553

Attachment 341451: Patch

https://bugs.webkit.org/attachment.cgi?id=341451&action=review




--- Comment #27 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 341451
  --> https://bugs.webkit.org/attachment.cgi?id=341451
Patch

With this patch applied, trying to open the menu using the keyboard
(for example with the dedicated context menu that some keyboards have)
results in the following errors:

(MiniBrowser:26141): Gtk-WARNING **: no trigger event for menu popup
(MiniBrowser:26141): Gtk-CRITICAL **: gtk_menu_popup_at_rect: assertion
'GDK_IS_WINDOW (rect_window)' failed

Let's not land this yet, I'll try to figure out what to do in that case.