[webkit-reviews] review granted: [Bug 186023] [WTF] Add clz32 / clz64 for MSVC : [Attachment 341428] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 186023: [WTF] Add clz32 / clz64 for MSVC
https://bugs.webkit.org/show_bug.cgi?id=186023

Attachment 341428: Patch

https://bugs.webkit.org/attachment.cgi?id=341428&action=review




--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 341428
  --> https://bugs.webkit.org/attachment.cgi?id=341428
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341428&action=review

> Source/WTF/wtf/MathExtras.h:534
> +    // Visual Studio 2008 or upper have __lzcnt But we can't detect AVX at
compile time.

upper  => later
“ But”	=> “, but”

What does AVX stand for?

> Source/WTF/wtf/MathExtras.h:535
> +    // So we use bsr to calculate clz

Is bsr an industry standard shorthand for _BitScanReverse()? If not, I suggest
writing it out.

> Source/WTF/wtf/MathExtras.h:559
> +    // Visual Studio 2008 or upper have __lzcnt But we can't detect AVX at
compile time.

Sam remark as line 534.

> Source/WTF/wtf/MathExtras.h:560
> +    // So we use bsr to calculate clz

Same remark as for line 535.