[webkit-reviews] review granted: [Bug 186024] Modernize SVGRenderStyleDefs.h : [Attachment 341438] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 186024: Modernize SVGRenderStyleDefs.h
https://bugs.webkit.org/show_bug.cgi?id=186024

Attachment 341438: Patch

https://bugs.webkit.org/attachment.cgi?id=341438&action=review




--- Comment #5 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 341438
  --> https://bugs.webkit.org/attachment.cgi?id=341438
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341438&action=review

> Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.cpp:61
> +AlignmentBaseline
SVGTextLayoutEngineBaseline::dominantBaselineToAlignmentBaseline(bool
isVerticalText, const RenderObject* textRenderer) const

This is fine as-is. Would be great to make textRenderer a const lvalue
reference instead of a pointer and then remove at least the first ASSERT. This
would be good to do in a follow up.

> Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.cpp:100
>      default:

This is ok as-is. Would be great if we can remove the default case and let the
compiler enforce the enum.