[webkit-reviews] review granted: [Bug 186014] testair sometimes crashes due to races in initialization of ARC4RandomNumberGenerator : [Attachment 341405] the patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 186014: testair sometimes crashes due to races in initialization of
ARC4RandomNumberGenerator
https://bugs.webkit.org/show_bug.cgi?id=186014

Attachment 341405: the patch

https://bugs.webkit.org/attachment.cgi?id=341405&action=review




--- Comment #2 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 341405
  --> https://bugs.webkit.org/attachment.cgi?id=341405
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341405&action=review

r=me I think WTF::RandomDevice would reuire similar change.

> Source/JavaScriptCore/runtime/JSString.cpp:58
> +	   dataLog("Really destroying string.\n");

This part seems accidentally included.

> Source/WTF/wtf/CryptographicallyRandomNumber.cpp:162
> +    static ARC4RandomNumberGenerator* randomNumberGenerator;

I think LazyNeverDestroyed is better.