[webkit-reviews] review granted: [Bug 186009] [iOS] Fix warnings about leaks found by clang static analyzer : [Attachment 341390] Patch v2

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 186009: [iOS] Fix warnings about leaks found by clang static analyzer
https://bugs.webkit.org/show_bug.cgi?id=186009

Attachment 341390: Patch v2

https://bugs.webkit.org/attachment.cgi?id=341390&action=review




--- Comment #9 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 341390
  --> https://bugs.webkit.org/attachment.cgi?id=341390
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=341390&action=review

>
Source/ThirdParty/libwebrtc/Source/third_party/opus/src/src/opus_compare.c:241
> +    free(x);

We should upstream these fixes. For now, it’s fine that you include a patch.

>
Source/ThirdParty/libwebrtc/Source/third_party/usrsctp/usrsctplib/user_socket.c
:2134
> +	struct sockaddr *sa = NULL;

Ditto.

> Source/WebCore/Modules/webauthn/cocoa/LocalAuthenticator.mm:310
> +		       ASSERT(((NSData *)publicKeyDataRef.get()).length == (1 +
2*ES256KeySizeInBytes)); // 04 | X | Y

Missing spaces around *. Surprised style checker didn’t catch this.

> Source/WebCore/Modules/webauthn/cocoa/LocalAuthenticator.mm:353
> +		       NSData *nsSignature = (NSData *)signatureRef.get();

Could use auto here since we cast on the right hand side.

> Source/WebCore/Modules/webauthn/cocoa/LocalAuthenticator.mm:510
> +	       NSData *nsSignature = (NSData *)signatureRef.get();

Ditto.

> Source/WebCore/bridge/objc/WebScriptObject.mm:661
> +	   sharedUndefined.get() = adoptNS([super allocWithZone:NULL]);

NULL  => nullptr