[webkit-reviews] review denied: [Bug 183586] Custom Elements: connectedCallback is invoked at unexpected timing : [Attachment 341272] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 25 20:11:05 PDT 2018
Ryosuke Niwa <rniwa at webkit.org> has denied review:
Bug 183586: Custom Elements: connectedCallback is invoked at unexpected timing
https://bugs.webkit.org/show_bug.cgi?id=183586
Attachment 341272: Patch
https://bugs.webkit.org/attachment.cgi?id=341272&action=review
--- Comment #22 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 341272
--> https://bugs.webkit.org/attachment.cgi?id=341272
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=341272&action=review
> Source/WebCore/dom/Element.cpp:1981
> + if (!data.customElementReactionQueue()) {
> +
data.setCustomElementReactionQueue(std::make_unique<CustomElementReactionQueue>
(elementInterface));
r- because of this change.
More information about the webkit-reviews
mailing list