[webkit-reviews] review granted: [Bug 184897] Web Inspector: Annotate Same-Site cookies : [Attachment 341326] Patch and layout test

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 184897: Web Inspector: Annotate Same-Site cookies
https://bugs.webkit.org/show_bug.cgi?id=184897

Attachment 341326: Patch and layout test

https://bugs.webkit.org/attachment.cgi?id=341326&action=review




--- Comment #9 from Brian Burg <bburg at apple.com> ---
Comment on attachment 341326
  --> https://bugs.webkit.org/attachment.cgi?id=341326
Patch and layout test

View in context: https://bugs.webkit.org/attachment.cgi?id=341326&action=review

r=me, great patch. Let's wait for EWS, I anticipate nitpicking
platform-specific results.

> Source/WebCore/platform/Cookie.h:171
> +    using values = EnumValues<

This is cool.

> Source/WebCore/platform/network/cocoa/CookieCocoa.mm:39
> +static NSString * const NSHTTPCookieSameSiteStrict = @"strict";

This stuff should be in NSHTTPCookieSPI, but that file doesn't exist yet.

> LayoutTests/http/tests/inspector/network/har/har-page-expected.txt:718
> +		 "sameSite": "Lax"

I believe we may need different expectations per port, if this isn't going to
be propagated. Let's see what EWS says.