[webkit-reviews] review granted: [Bug 185986] URL::host should return a StringView to reduce allocations : [Attachment 341310] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 185986: URL::host should return a StringView to reduce allocations
https://bugs.webkit.org/show_bug.cgi?id=185986

Attachment 341310: Patch

https://bugs.webkit.org/attachment.cgi?id=341310&action=review




--- Comment #4 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 341310
  --> https://bugs.webkit.org/attachment.cgi?id=341310
Patch

In file included from
/home/ews-wpe/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources
/UnifiedSource382.cpp:8:0:
../../Source/WebCore/platform/network/soup/SoupNetworkSession.cpp: In static
member function ‘static std::optional<WebCore::ResourceError>
WebCore::SoupNetworkSession::checkTLSErrors(const WebCore::URL&,
GTlsCertificate*, GTlsCertificateFlags)’:
../../Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:280:58:
error: no matching function for call to ‘WTF::HashMap<WTF::String,
WebCore::HostTLSCertificateSet,
WTF::ASCIICaseInsensitiveHash>::find(WTF::StringView)’
     auto it = clientCertificates().find(requestURL.host());
							  ^