[webkit-reviews] review granted: [Bug 185932] Make a memory test where we can validate JSCs mini memory mode : [Attachment 341300] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 25 11:02:12 PDT 2018


Mark Lam <mark.lam at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 185932: Make a memory test where we can validate JSCs mini memory mode
https://bugs.webkit.org/show_bug.cgi?id=185932

Attachment 341300: patch

https://bugs.webkit.org/attachment.cgi?id=341300&action=review




--- Comment #25 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 341300
  --> https://bugs.webkit.org/attachment.cgi?id=341300
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341300&action=review

r=me

> Tools/Scripts/run-testmem:178
> +	       print "#{statusToPrint}\r"
> +	       scores[path].push(runTest(path, iters))
> +	       print "#{" ".rjust(statusToPrint.length)}\r"

Why the strange use of print + "\r" instead of just a plain puts?


More information about the webkit-reviews mailing list