[webkit-reviews] review granted: [Bug 185975] Ensure that the Web Content process doesn't sleep during initialization : [Attachment 341256] Patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 185975: Ensure that the Web Content process doesn't sleep during
initialization
https://bugs.webkit.org/show_bug.cgi?id=185975

Attachment 341256: Patch

https://bugs.webkit.org/attachment.cgi?id=341256&action=review




--- Comment #5 from Andy Estes <aestes at apple.com> ---
Comment on attachment 341256
  --> https://bugs.webkit.org/attachment.cgi?id=341256
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341256&action=review

> Source/WebKit/UIProcess/WebProcessPool.cpp:983
> +    // This must remain after the last message sent in this function,
> +    // otherwise the Web Content process could be suspended before
> +    // initialization is complete.
> +    process.didSendAllProcessInitializationMessages();

Could you use a ScopeExit for this to ensure this always runs last? I'm worried
that maybe someone will add an early return in the future.