[webkit-reviews] review granted: [Bug 185948] [GStreamer] Handle changes in the "drm-preferred-decryption-system-id" NEED_CONTEXT message. : [Attachment 341282] Patch.

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Thibault Saunier
<tsaunier at gnome.org>'s request for review:
Bug 185948: [GStreamer] Handle changes in the
"drm-preferred-decryption-system-id" NEED_CONTEXT message.
https://bugs.webkit.org/show_bug.cgi?id=185948

Attachment 341282: Patch.

https://bugs.webkit.org/attachment.cgi?id=341282&action=review




--- Comment #10 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 341282
  --> https://bugs.webkit.org/attachment.cgi?id=341282
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=341282&action=review

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
319
> +    if (streamEncryptionAllowedSystems) {
> +	   for (i = 0; streamEncryptionAllowedSystems[i]; ++i)
> +	      
streamEncryptionAllowedSystemsVector.append(streamEncryptionAllowedSystems[i]);
> +    }

We don't need the brackets here, I think.

> Tools/gstreamer/jhbuild.modules:74
> +	 <patch
file="gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-
s.patch" strip="1" />

You can add a comment <!-- Merged in master, scheduled for 1.16.0 --> because
we don't have the commit id yet but we will and we want to ensure that it is
clear where it is now and will be release. Actually, the information about the
patches scheduled for 1.16 should be in the others too.