[webkit-reviews] review granted: [Bug 185814] [Win][MiniBrowser] Add MiniBrowserWindow class : [Attachment 341268] Patch

[bugzilla-daemon at webkit.org]

Per Arne Vollan <pvollan at apple.com> has granted  review:
Bug 185814: [Win][MiniBrowser] Add MiniBrowserWindow class
https://bugs.webkit.org/show_bug.cgi?id=185814

Attachment 341268: Patch

https://bugs.webkit.org/attachment.cgi?id=341268&action=review




--- Comment #14 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 341268
  --> https://bugs.webkit.org/attachment.cgi?id=341268
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341268&action=review

R=me.

> Tools/MiniBrowser/win/MainWindow.cpp:36
> +#define URLBAR_HEIGHT  24
> +#define CONTROLBUTTON_WIDTH 24

I think I would prefer to make these constexpr inside the resizeSubViews
method.

> Tools/MiniBrowser/win/MainWindow.cpp:52
> +LRESULT CALLBACK EditProc(HWND, UINT, WPARAM, LPARAM);
> +LRESULT CALLBACK BackButtonProc(HWND, UINT, WPARAM, LPARAM);
> +LRESULT CALLBACK ForwardButtonProc(HWND, UINT, WPARAM, LPARAM);
> +LRESULT CALLBACK ReloadButtonProc(HWND, UINT, WPARAM, LPARAM);
> +INT_PTR CALLBACK About(HWND, UINT, WPARAM, LPARAM);
> +INT_PTR CALLBACK CustomUserAgent(HWND, UINT, WPARAM, LPARAM);
> +INT_PTR CALLBACK Caches(HWND, UINT, WPARAM, LPARAM);
> +INT_PTR CALLBACK AuthDialogProc(HWND, UINT, WPARAM, LPARAM);

Could these functions also be static members of the MainWindow class?

> Tools/MiniBrowser/win/MainWindow.cpp:62
> +    LoadString(hInst, IDC_MINIBROWSER, buff, length);

The second parameter of LoadString should be 'id', I believe.