[webkit-reviews] review granted: [Bug 183586] Custom Elements: connectedCallback is invoked at unexpected timing : [Attachment 341272] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Rob Buis <rbuis at igalia.com>'s
request for review:
Bug 183586: Custom Elements: connectedCallback is invoked at unexpected timing
https://bugs.webkit.org/show_bug.cgi?id=183586

Attachment 341272: Patch

https://bugs.webkit.org/attachment.cgi?id=341272&action=review




--- Comment #19 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 341272
  --> https://bugs.webkit.org/attachment.cgi?id=341272
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341272&action=review

Looks sane to me.

r=me

> Source/WebCore/html/parser/HTMLDocumentParser.cpp:210
> +	      
m_treeBuilder->didCreateCustomOrCallbackElement(WTFMove(newElement),
*constructionData);

This patch is ok as-is. We always execute this line. I suggest we move this
line to be above the return (line 212) instead of duplicating it in both
branches.