[webkit-reviews] review granted: [Bug 185741] Web Inspector: Popover dismissed while attempting to move cursor inside : [Attachment 341238] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 24 20:24:32 PDT 2018


Joseph Pecoraro <joepeck at webkit.org> has granted Matt Baker
<mattbaker at apple.com>'s request for review:
Bug 185741: Web Inspector: Popover dismissed while attempting to move cursor
inside
https://bugs.webkit.org/show_bug.cgi?id=185741

Attachment 341238: Patch

https://bugs.webkit.org/attachment.cgi?id=341238&action=review




--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 341238
  --> https://bugs.webkit.org/attachment.cgi?id=341238
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341238&action=review

> Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js:1819
> +		   let intersection =
bounds.intersectionWithRect(this._popover.frame);

Nice! Should we expand this a little around the edges, or is it mostly just the
transparent portion next to the "arrow" edge?


More information about the webkit-reviews mailing list