[webkit-reviews] review granted: [Bug 185956] Optimize ImageDecoderCG::frameAllowSubsamplingAtIndex() for non-JPEG images : [Attachment 341219] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 185956: Optimize ImageDecoderCG::frameAllowSubsamplingAtIndex() for
non-JPEG images
https://bugs.webkit.org/show_bug.cgi?id=185956

Attachment 341219: Patch

https://bugs.webkit.org/attachment.cgi?id=341219&action=review




--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 341219
  --> https://bugs.webkit.org/attachment.cgi?id=341219
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341219&action=review

r=me

> Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:388
> +    // Workaround for <rdar://problem/5184655> - Hang rendering very large
progressive JPEG. Decoding progressive
> +    // images hangs for a very long time right now. Until this is fixed,
don't sub-sample progressive images. This
> +    // will cause them to fail our large image check and they won't be
decoded.
> +    // FIXME: Remove once underlying issue is fixed
(<rdar://problem/5191418>)

This patch is fine -- but the FIXME here is about a bug that was fixed in 2014.
Maybe we should just remove this code entirely?