[webkit-reviews] review granted: [Bug 185782] [Curl] Allow passing contents of Root CA data directly. : [Attachment 340739] PATCH

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 185782: [Curl] Allow passing contents of Root CA data directly.
https://bugs.webkit.org/show_bug.cgi?id=185782

Attachment 340739: PATCH

https://bugs.webkit.org/attachment.cgi?id=340739&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 340739
  --> https://bugs.webkit.org/attachment.cgi?id=340739
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=340739&action=review

> Source/WebCore/platform/network/curl/CurlSSLHandle.cpp:85
> +	   caCertData.append(caCertString.data(), caCertString.length());

This create a string temporarily.
Maybe there is a way to use StringView so that you can directly create a
Vector<char> from it.

> Source/WebCore/platform/network/curl/CurlSSLHandle.cpp:86
> +	   setCACertData(WTFMove(caCertData));

Early return.