[webkit-reviews] review granted: [Bug 185925] OSBuildFetcher should respect maxRevision while finding OS builds to report. : [Attachment 341148] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted dewei_zhu at apple.com's request for
review:
Bug 185925: OSBuildFetcher should respect maxRevision while finding OS builds
to report.
https://bugs.webkit.org/show_bug.cgi?id=185925

Attachment 341148: Patch

https://bugs.webkit.org/attachment.cgi?id=341148&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 341148
  --> https://bugs.webkit.org/attachment.cgi?id=341148
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341148&action=review

> Websites/perf.webkit.org/tools/js/os-build-fetcher.js:101
> -		   .filter((commit) => commit['order'] > minOrder);
> +		   .filter((commit) => commit['order'] > minOrder &&
commit['order'] < maxOrder);

It seems that minOrder & maxOrder should be inclusive.