[webkit-reviews] review granted: [Bug 185923] InPlaceAbstractState should filter variables at the tail from a GetLocal by their flush format : [Attachment 341140] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 185923: InPlaceAbstractState should filter variables at the tail from a
GetLocal by their flush format
https://bugs.webkit.org/show_bug.cgi?id=185923

Attachment 341140: Patch

https://bugs.webkit.org/attachment.cgi?id=341140&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 341140
  --> https://bugs.webkit.org/attachment.cgi?id=341140
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341140&action=review

r=me

> Source/JavaScriptCore/dfg/DFGInPlaceAbstractState.cpp:251
> +		   // format says it will be. The value may claim to have
changed abstract state
> +		   // but it's type from abstract state. For example:

This sentence doesn't make sense:
"The value may claim to have changed abstract state but it's type from abstract
state"