[webkit-reviews] review granted: [Bug 185839] Avoid loading AVFoundation to check supported MIME types if possible : [Attachment 341126] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 23 14:07:39 PDT 2018


Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 185839: Avoid loading AVFoundation to check supported MIME types if
possible
https://bugs.webkit.org/show_bug.cgi?id=185839

Attachment 341126: Patch

https://bugs.webkit.org/attachment.cgi?id=341126&action=review




--- Comment #17 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 341126
  --> https://bugs.webkit.org/attachment.cgi?id=341126
Patch

r=me with a general nit. Rather than check whether the m_cache.isEmpty() to see
whether it's been initialized, it might be better to have a "bool
m_isInitialized" or change m_cache to an std::optional. That way, you can
disambiguate between "the list of supported mime types is empty" and "the cache
hasn't been initialized yet".


More information about the webkit-reviews mailing list