[webkit-reviews] review granted: [Bug 185757] Don't create the SubimageCache just to clear an image from it : [Attachment 341101] Patch v4

[bugzilla-daemon at webkit.org]

Said Abou-Hallawa <sabouhallawa at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 185757: Don't create the SubimageCache just to clear an image from it
https://bugs.webkit.org/show_bug.cgi?id=185757

Attachment 341101: Patch v4

https://bugs.webkit.org/attachment.cgi?id=341101&action=review




--- Comment #16 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
Comment on attachment 341101
  --> https://bugs.webkit.org/attachment.cgi?id=341101
Patch v4

View in context: https://bugs.webkit.org/attachment.cgi?id=341101&action=review

> Source/WebCore/platform/graphics/cg/SubimageCacheWithTimer.h:83
> -    typedef HashSet<SubimageCacheEntry, SubimageCacheHash,
SubimageCacheEntryTraits> SubimageCache;
> +    typedef HashSet<SubimageCacheEntry, SubimageCacheHash,
SubimageCacheEntryTraits> SubimageCacheHashSet;

Nit: I think this typedef can be private also.