[webkit-reviews] review granted: [Bug 185898] [LFC] Move sizing/positioning logic to helper classes : [Attachment 341064] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 185898: [LFC] Move sizing/positioning logic to helper classes
https://bugs.webkit.org/show_bug.cgi?id=185898

Attachment 341064: Patch

https://bugs.webkit.org/attachment.cgi?id=341064&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 341064
  --> https://bugs.webkit.org/attachment.cgi?id=341064
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341064&action=review

> Source/WebCore/layout/FormattingContext.cpp:66
> +	   computedTopLeft =
FormattingContextGeometry::outOfFlowReplacedPosition(layoutContext, layoutBox);

Maybe FormattingContextGeometry could be an inner class of FormattingContext
(FormattingContext::Geometry)?

This way you could just write Geometry::outOfFlowReplacedPosition(...) here.