[webkit-reviews] review granted: [Bug 184261] [GTK][WPE] Memory pressure monitor doesn't reliable notify all the subprocesses : [Attachment 341087] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 23 06:47:48 PDT 2018
Carlos Garcia Campos <cgarcia at igalia.com> has granted Carlos Alberto Lopez
Perez <clopez at igalia.com>'s request for review:
Bug 184261: [GTK][WPE] Memory pressure monitor doesn't reliable notify all the
subprocesses
https://bugs.webkit.org/show_bug.cgi?id=184261
Attachment 341087: Patch
https://bugs.webkit.org/attachment.cgi?id=341087&action=review
--- Comment #20 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 341087
--> https://bugs.webkit.org/attachment.cgi?id=341087
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=341087&action=review
This looks good to me, but it requires a WebKit2 owner approval
> Source/WebKit/UIProcess/Plugins/PluginProcessManager.cpp:139
> + PluginProcessProxy* pluginProxy = pluginProcess.get();
> + if (pluginProxy)
why do you need another variable?
More information about the webkit-reviews
mailing list