[webkit-reviews] review denied: [Bug 183586] Custom Elements: connectedCallback is invoked at unexpected timing : [Attachment 341004] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Rob Buis <rbuis at igalia.com>'s
request for review:
Bug 183586: Custom Elements: connectedCallback is invoked at unexpected timing
https://bugs.webkit.org/show_bug.cgi?id=183586

Attachment 341004: Patch

https://bugs.webkit.org/attachment.cgi?id=341004&action=review




--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 341004
  --> https://bugs.webkit.org/attachment.cgi?id=341004
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341004&action=review

> Source/WebCore/html/parser/HTMLDocumentParser.cpp:204
> +	       // 6.2.1. Set result to a new element that implements the
HTMLElement interface, with no attributes, namespace set to the HTML namespace,

No need to have these comments. The above link to the spec is sufficient.

> Source/WebCore/html/parser/HTMLDocumentParser.cpp:205
> +	       // namespace prefix set to prefix, local name set to localName,
custom element state set to "undefined", and node document set to document.

Please remove.

> Source/WebCore/html/parser/HTMLDocumentParser.cpp:206
> +	       auto newElement = HTMLElement::create(QualifiedName(nullAtom(),
constructionData->name, HTMLNames::xhtmlNamespaceURI), *document());

Please assert Document::validateCustomElementName(constructionData->name) here.

> Source/WebCore/html/parser/HTMLDocumentParser.cpp:207
> +	       // 6.2.2. Enqueue a custom element upgrade reaction given result
and definition.

Ditto.

> LayoutTests/imported/w3c/ChangeLog:8
> +	   *
web-platform-tests/custom-elements/connected-callbacks-html-fragment-parsing.ht
ml: Added.

Don't add a test to LayoutTests/imported/w3c. Add it to fast/custom-elements
instead.
r- because adding a test test to LayoutTests/imported/ is forbidden.