[webkit-reviews] review granted: [Bug 180398] WebDriver: implement maximize, minimize and fullscreen window commands : [Attachment 340956] Try to fix iOS builds

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 22 13:18:52 PDT 2018

Brian Burg <bburg at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 180398: WebDriver: implement maximize, minimize and fullscreen window

Attachment 340956: Try to fix iOS builds


--- Comment #6 from Brian Burg <bburg at apple.com> ---
Comment on attachment 340956
  --> https://bugs.webkit.org/attachment.cgi?id=340956
Try to fix iOS builds

View in context: https://bugs.webkit.org/attachment.cgi?id=340956&action=review

r=me except GObject parts in WebKitWebViewGTK.cpp, which I do not understand.

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewGtk.cpp:118
> +	   completeTimer.startOneShot(1_s);

Seems like a good idea, though I've never had it flake out on macOS yet.

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewGtk.cpp:190

Why is this part guarded?

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewGtk.cpp:196
> +	       gtk_window_move(window, screenRect.x(), screenRect.y());

Should this be (0,0), or are the coordinates flipped somehow?

More information about the webkit-reviews mailing list