[webkit-reviews] review granted: [Bug 144525] DFG::LICMPhase should attempt to hoist edge type checks if hoisting the whole node fails : [Attachment 340865] patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 144525: DFG::LICMPhase should attempt to hoist edge type checks if hoisting
the whole node fails
https://bugs.webkit.org/show_bug.cgi?id=144525

Attachment 340865: patch

https://bugs.webkit.org/attachment.cgi?id=340865&action=review




--- Comment #10 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 340865
  --> https://bugs.webkit.org/attachment.cgi?id=340865
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340865&action=review

> Source/JavaScriptCore/dfg/DFGUseKind.h:310
> +    case Int32Use:
> +    case KnownInt32Use:
> +    case AnyIntUse:
> +    case NumberUse:

Why do we say that these crash when the input is empty?

Int32 check will only pass if the input is non-empty.  Probably ditto for a lot
of these.