[webkit-reviews] review granted: [Bug 185278] Remove dead exception in MediaList.appendMedium : [Attachment 339557] Add back GError parameter

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Chris Nardi <cnardi at chromium.org>'s
request for review:
Bug 185278: Remove dead exception in MediaList.appendMedium
https://bugs.webkit.org/show_bug.cgi?id=185278

Attachment 339557: Add back GError parameter

https://bugs.webkit.org/attachment.cgi?id=339557&action=review




--- Comment #12 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 339557
  --> https://bugs.webkit.org/attachment.cgi?id=339557
Add back GError parameter

View in context: https://bugs.webkit.org/attachment.cgi?id=339557&action=review

r=me with nit.

> Source/WebCore/css/MediaList.cpp:211
> +    bool added = m_mediaQueries->add(medium);

I do not think we need this local. Could be:
if (!m_mediaQueries->add(medium))
    return;