[webkit-reviews] review granted: [Bug 185003] We should have a CoW storage for NewArrayBuffer arrays. : [Attachment 340900] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 21 15:23:08 PDT 2018


Filip Pizlo <fpizlo at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 185003: We should have a CoW storage for NewArrayBuffer arrays.
https://bugs.webkit.org/show_bug.cgi?id=185003

Attachment 340900: Patch

https://bugs.webkit.org/attachment.cgi?id=340900&action=review




--- Comment #21 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 340900
  --> https://bugs.webkit.org/attachment.cgi?id=340900
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340900&action=review

> Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.h:308
> +    static std::tuple<unsigned, IndexingType>
decopressArrayAllocationProfile(UnlinkedArrayAllocationProfile
compressedProfile)

*decompress, unless "decopress" is a term of art somehow

> Source/JavaScriptCore/dfg/DFGArrayMode.cpp:60
> +	   if (action == Array::Write && observed &
asArrayModes(toIndexingShape(type) | ArrayClass | CopyOnWrite))

Can you use some parentheses here?  a && b & c has unclear precedence.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:874
> -    
> +

Revert

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:900
> -    
> +

Revert

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:2113
> -    
> +

Revert

> JSTests/ChangeLog:11
> +2018-05-21  Keith Miller  <keith_miller at apple.com>
> +
> +	   We should have a CoW storage for NewArrayBuffer arrays.
> +	   https://bugs.webkit.org/show_bug.cgi?id=185003
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * stress/put-on-cow-prototype.js: Added.
> +	   (putByVal):
> +	   (putById):
> +

Can has more tests? :-P


More information about the webkit-reviews mailing list