[webkit-reviews] review denied: [Bug 183583] connectedCallback called when disconnected : [Attachment 340871] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Rob Buis <rbuis at igalia.com>'s
request for review:
Bug 183583: connectedCallback called when disconnected
https://bugs.webkit.org/show_bug.cgi?id=183583

Attachment 340871: Patch

https://bugs.webkit.org/attachment.cgi?id=340871&action=review




--- Comment #8 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 340871
  --> https://bugs.webkit.org/attachment.cgi?id=340871
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340871&action=review

I don't think this change is correct. For that matter, I believe WebKit's
current behavior is in accordance with the specification.

> Source/WebCore/dom/CustomElementReactionQueue.cpp:80
> -	       elementInterface.invokeConnectedCallback(element);
> +	       if (element.isConnected())
> +		   elementInterface.invokeConnectedCallback(element);

There is no spec text which mandates a check like this:
https://html.spec.whatwg.org/multipage/custom-elements.html#invoke-custom-eleme
nt-reactions

> LayoutTests/fast/custom-elements/connected-callback.html:12
> +	   while (this.firstChild) {

Why while?