[webkit-reviews] review granted: [Bug 185773] File's structured serialization should serialize lastModified attribute : [Attachment 340747] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 185773: File's structured serialization should serialize lastModified
attribute
https://bugs.webkit.org/show_bug.cgi?id=185773

Attachment 340747: Patch

https://bugs.webkit.org/attachment.cgi?id=340747&action=review




--- Comment #10 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 340747
  --> https://bugs.webkit.org/attachment.cgi?id=340747
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340747&action=review

> Source/WebCore/fileapi/File.h:87
> +    const std::optional<double>& lastModifiedOverride() const { return
m_overrideLastModifiedDate; }

Is there a reason to  pass a std::optional<double> in deserialize but here
return a const& ?

> Source/WebCore/fileapi/File.h:115
> +    std::optional<double> m_overrideLastModifiedDate;

I guess this is mandated by File IDL?

>
LayoutTests/imported/w3c/web-platform-tests/workers/semantics/structured-clone/
shared-expected.txt:1
> +CONSOLE MESSAGE: line 19: ReferenceError: Can't find variable: SharedWorker

Might want to skip this one.