[webkit-reviews] review requested: [Bug 183744] Add some tests for lldb_webkit.py : [Attachment 340870] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 21 12:16:47 PDT 2018


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 183744: Add some tests for lldb_webkit.py
https://bugs.webkit.org/show_bug.cgi?id=183744

Attachment 340870: Patch

https://bugs.webkit.org/attachment.cgi?id=340870&action=review




--- Comment #7 from Daniel Bates <dbates at webkit.org> ---
Created attachment 340870

  --> https://bugs.webkit.org/attachment.cgi?id=340870&action=review

Patch

Updated patch that runs the lldb tests in a new Python process to avoid the
+[__MDQuery initialize] issue. This allows us to run the lldb tests in
parallel. Although this approach speeds up the tests ~20%, running
"test-webkitpy" takes a little more than double the amount of time it takes
today: ~12.978666666666667s with the lldb tests vs ~7s without the lldb tests.
I am open to ideas/suggestions on how we can further speed the lldb tests up.


More information about the webkit-reviews mailing list