[webkit-reviews] review granted: [Bug 185815] WebView._preferencesChanged should apply colorFilterEnabled preference before parsing user stylesheet : [Attachment 340830] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 21 08:44:39 PDT 2018


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 185815: WebView._preferencesChanged should apply colorFilterEnabled
preference before parsing user stylesheet
https://bugs.webkit.org/show_bug.cgi?id=185815

Attachment 340830: patch

https://bugs.webkit.org/attachment.cgi?id=340830&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 340830
  --> https://bugs.webkit.org/attachment.cgi?id=340830
patch

Would be nice to break this messy function up to be more explicit about
ordering dependencies.


More information about the webkit-reviews mailing list