[webkit-reviews] review granted: [Bug 185779] Handle failure to extend sandbox gracefully : [Attachment 340729] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 18 12:45:25 PDT 2018


Brent Fulgham <bfulgham at webkit.org> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 185779: Handle failure to extend sandbox gracefully
https://bugs.webkit.org/show_bug.cgi?id=185779

Attachment 340729: Patch

https://bugs.webkit.org/attachment.cgi?id=340729&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 340729
  --> https://bugs.webkit.org/attachment.cgi?id=340729
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340729&action=review

Looks great! r=me

> Source/WebKit/UIProcess/UserMediaProcessManager.cpp:186
> +    UNUSED_PARAM(proxy);

You probably don't need UNUSED_PARAM here, since proxy is used below.


More information about the webkit-reviews mailing list