[webkit-reviews] review granted: [Bug 183089] [Curl] Bug fix on suspend/resume behavior. : [Attachment 340683] Fixed

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 183089: [Curl] Bug fix on suspend/resume behavior.
https://bugs.webkit.org/show_bug.cgi?id=183089

Attachment 340683: Fixed

https://bugs.webkit.org/attachment.cgi?id=340683&action=review




--- Comment #23 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 340683
  --> https://bugs.webkit.org/attachment.cgi?id=340683
Fixed

r=me 

I am not sure using mutex is the right way of doing things.
Please consider whether posting task to the background thread might not be a
clearer and stronger approach.

View in context: https://bugs.webkit.org/attachment.cgi?id=340683&action=review

> Source/WebCore/platform/network/curl/CurlRequest.h:188
> +    bool isHandlePaused() const;

I would put these getters above, not in the middle of member definitions.