[webkit-reviews] review granted: [Bug 185755] We don't throw SyntaxErrors for runtime generated regular expressions with errors : [Attachment 340668] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 185755: We don't throw SyntaxErrors for runtime generated regular
expressions with errors
https://bugs.webkit.org/show_bug.cgi?id=185755

Attachment 340668: Patch

https://bugs.webkit.org/attachment.cgi?id=340668&action=review




--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 340668
  --> https://bugs.webkit.org/attachment.cgi?id=340668
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340668&action=review

r=me.

> Source/JavaScriptCore/runtime/RegExpConstructor.cpp:286
> +		   throwException(exec, scope, regExp->errorToThrow(exec));

shouldn't there be a return here? Why create an invalid RegExp?