[webkit-reviews] review granted: [Bug 185752] Lazily create WebCore::Timer for WebCore::Image : [Attachment 340663] Patch v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 17 16:20:38 PDT 2018
Simon Fraser (smfr) <simon.fraser at apple.com> has granted David Kilzer
(:ddkilzer) <ddkilzer at webkit.org>'s request for review:
Bug 185752: Lazily create WebCore::Timer for WebCore::Image
https://bugs.webkit.org/show_bug.cgi?id=185752
Attachment 340663: Patch v1
https://bugs.webkit.org/attachment.cgi?id=340663&action=review
--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 340663
--> https://bugs.webkit.org/attachment.cgi?id=340663
Patch v1
View in context: https://bugs.webkit.org/attachment.cgi?id=340663&action=review
> Source/WebCore/platform/graphics/Image.cpp:351
> + std::call_once(onceFlag, [this] {
Don't need call_once. Just if (!m_animationStartTimer)
> Source/WebCore/platform/graphics/Image.h:203
> + std::once_flag onceFlag;
Don't need this here.
More information about the webkit-reviews
mailing list