[webkit-reviews] review granted: [Bug 185734] CRASH in ImageDecoderAVFObjC::sampleAtIndex() : [Attachment 340603] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 185734: CRASH in ImageDecoderAVFObjC::sampleAtIndex()
https://bugs.webkit.org/show_bug.cgi?id=185734

Attachment 340603: Patch

https://bugs.webkit.org/attachment.cgi?id=340603&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 340603
  --> https://bugs.webkit.org/attachment.cgi?id=340603
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340603&action=review

> LayoutTests/fast/images/animated-image-mp4-crash.html:8
> +	   var imageData;

Nit: "var" here "let" below, should be consistent.

> LayoutTests/fast/images/animated-image-mp4-crash.html:12
> +		   let image = document.querySelector('img');

Nit: could use const here instead of let.