[webkit-reviews] review granted: [Bug 185736] Ensure valid rects for fullsceen animation. : [Attachment 340599] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 185736: Ensure valid rects for fullsceen animation.
https://bugs.webkit.org/show_bug.cgi?id=185736

Attachment 340599: Patch

https://bugs.webkit.org/attachment.cgi?id=340599&action=review




--- Comment #3 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 340599
  --> https://bugs.webkit.org/attachment.cgi?id=340599
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340599&action=review

r=me with nit:

> Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:507
> +    
> +    _initialFrame.size.width = std::max(_initialFrame.size.width, 1.0);
> +    _initialFrame.size.height = std::max(_initialFrame.size.height, 1.0);

You could have a helper function here:

static CGSize sizeExpandedToSize(CGSize initial, CGSize other)
{
    return CGSizeMake(std::max(initial.width, other.width), 
std::max(initial.height, other.height));
}