[webkit-reviews] review granted: [Bug 185706] [iOS] Update AirPlay route monitoring : [Attachment 340591] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 185706: [iOS] Update AirPlay route monitoring
https://bugs.webkit.org/show_bug.cgi?id=185706

Attachment 340591: Patch

https://bugs.webkit.org/attachment.cgi?id=340591&action=review




--- Comment #3 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 340591
  --> https://bugs.webkit.org/attachment.cgi?id=340591
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340591&action=review

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:463
> +	   if (!protectedSelf->_callback)
>	       return;
>  
> -	   _callback->applicationWillEnterForeground(isSuspendedUnderLock);
> +	  
protectedSelf->_callback->applicationWillEnterForeground(isSuspendedUnderLock);

Nit: this and the next 4 instances of this pattern could have a reversed if
case:

if (auto* callback = protectedSelf->callback)
    callback->applicationWillEnterForeground(isSuspendedUnderLock);