[webkit-reviews] review granted: [Bug 177684] Cannot unset transition with important : [Attachment 340575] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 17 05:32:35 PDT 2018


Frédéric Wang (:fredw) <fred.wang at free.fr> has granted Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 177684: Cannot unset transition with important
https://bugs.webkit.org/show_bug.cgi?id=177684

Attachment 340575: Patch

https://bugs.webkit.org/attachment.cgi?id=340575&action=review




--- Comment #6 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 340575
  --> https://bugs.webkit.org/attachment.cgi?id=340575
Patch

Thanks, LGTM!

I was checking WPT and Chromium repositories and it seems they have the same
"cssom-remove-shorthand-property.html" as in WebKit: 

https://github.com/w3c/web-platform-tests/blob/master/css/cssom/cssom-setProper
ty-shorthand.html 
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/fast/css/cs
som-remove-shorthand-property.html

So I would instead propose to check the !important case in the same WPT file
and remove the duplicate from the WebKit/Chromium repository.


More information about the webkit-reviews mailing list