[webkit-reviews] review granted: [Bug 184914] Export changes to web-platform-test as part of the webkit-patch upload workflow : [Attachment 340424] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Brendan McLoughlin
<brendan at bocoup.com>'s request for review:
Bug 184914: Export changes to web-platform-test as part of the webkit-patch
upload workflow
https://bugs.webkit.org/show_bug.cgi?id=184914

Attachment 340424: Patch

https://bugs.webkit.org/attachment.cgi?id=340424&action=review




--- Comment #19 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 340424
  --> https://bugs.webkit.org/attachment.cgi?id=340424
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340424&action=review

> Tools/Scripts/webkitpy/tool/steps/wptchangeexport.py:52
> +	   message = 'Would you like to export the web-platform-tests changes
and/or create a PR to the WPT GitHub repository?'

Sorry to change my mind.
I think that we should phrase it as: "Would you like to export the
web-platform-tests changes to a WPT GitHub repository?"
" and/or ..." is not very clear.

> Tools/Scripts/webkitpy/w3c/test_exporter.py:140
> +	   return bool(self._create_patch())

We will probably create twice the patch, once when we will check for changes
and once when writing the git patch file.
Maybe we should store the patch data in TestExporter.

> Tools/Scripts/webkitpy/w3c/test_exporter.py:195
> +	   # validate token and username

Comment is probably not needed.