[webkit-reviews] review granted: [Bug 185644] Web Inspector: create a navigation item for toggling the overlay rulers/guides : [Attachment 340480] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 185644: Web Inspector: create a navigation item for toggling the overlay
rulers/guides
https://bugs.webkit.org/show_bug.cgi?id=185644

Attachment 340480: Patch

https://bugs.webkit.org/attachment.cgi?id=340480&action=review




--- Comment #9 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 340480
  --> https://bugs.webkit.org/attachment.cgi?id=340480
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340480&action=review

r=me, with the one change I mentioned.

After playing with this more, I really like that the zero label is shown along
with the first major tick mark on scroll-back. It's definitely a nice touch.

> Source/WebInspectorUI/UserInterface/Base/Setting.js:124
> +    showRulers: new WI.Setting("show-rulers", true),

This should be off by default. We can revisit this in the future as the feature
matures.