[webkit-reviews] review granted: [Bug 185654] Cleanup platform Cookie : [Attachment 340428] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 16 11:36:16 PDT 2018


Per Arne Vollan <pvollan at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 185654: Cleanup platform Cookie
https://bugs.webkit.org/show_bug.cgi?id=185654

Attachment 340428: Patch

https://bugs.webkit.org/attachment.cgi?id=340428&action=review




--- Comment #14 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 340428
  --> https://bugs.webkit.org/attachment.cgi?id=340428
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340428&action=review

R=me.

> Source/WebCore/platform/Cookie.h:62
> +	   return name.isNull() && value.isNull() && domain.isNull() &&
path.isNull() && !created

I think the previous version was more readable, but I leave this up to you.


More information about the webkit-reviews mailing list