[webkit-reviews] review granted: [Bug 182622] [CMake] Properly detect compiler flags, needed libs, and fallbacks for usage of 64-bit atomic operations : [Attachment 340473] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Alberto Garcia
<berto at igalia.com>'s request for review:
Bug 182622: [CMake] Properly detect compiler flags, needed libs, and fallbacks
for usage of 64-bit atomic operations
https://bugs.webkit.org/show_bug.cgi?id=182622

Attachment 340473: Patch

https://bugs.webkit.org/attachment.cgi?id=340473&action=review




--- Comment #27 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 340473
  --> https://bugs.webkit.org/attachment.cgi?id=340473
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340473&action=review

Clearly better than what we had before. I agree WebKitComplierFlags.cmake is a
good place for this test. Thanks, both of you!

> Source/cmake/OptionsGTK.cmake:19
> +set(THREADS_PREFER_PTHREAD_FLAG ON)

Add another blank line to separate it a bit from the install dirs.

> Source/cmake/OptionsWPE.cmake:14
> +set(THREADS_PREFER_PTHREAD_FLAG ON)

Ditto.